Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looks like it's missing the esptool part, that calculates the checksum byte, that goes right before the SHA256 sum. |
jp-bennett
requested changes
Oct 5, 2024
|
Oh man, does esptool.js not properly handle the checksum byte? It's gonna be a pain to calculate it yourself. |
|
Thinking about this again. I think we need to add a bit of logic to only rewrite the hashes if we actually do a string replace. Once that's in there, is it ready to ship? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jp-bennett seems to fail checksum, but this is the initial WIP
Closes #107