Explicitly define bone orientation including bone roll and anatomical rotation#17
Open
aaronfranke wants to merge 1 commit intomeshula:devfrom
Open
Explicitly define bone orientation including bone roll and anatomical rotation#17aaronfranke wants to merge 1 commit intomeshula:devfrom
aaronfranke wants to merge 1 commit intomeshula:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves discussion #4 in as explicit language as I possibly can without including screenshots. The old text about joint axes was under-specified, inconsistent with the dominant industry conventions, and has been replaced.
I also removed the old text about Euler rotation order. I don't think we should specify Euler rotation order, because we should expect that runtimes and file formats use Quaternions, Rotors, or other order-agnostic rotation representations. Also I'll mention that if people do want a specific rotation order, it is 100% portable to every application if you simply use 2 nodes and only rotate each node around a single axis.