Skip to content

Fix dataclass annotations bug #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richard-to merged 1 commit into from
Aug 3, 2026
Merged

Fix dataclass annotations bug #1398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mesop/dataclass_utils/dataclass_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@ def _recursive_update_dataclass_from_json_obj(instance: Any, json_dict: Any):
# and the instance has an attribute with a matching name,
# we assume the dict should be converted into a dataclass.
attr = getattr(instance, key)
item_instance = instance.__annotations__[key].__args__[0]()
type_hints = get_type_hints(type(instance))
item_instance = type_hints[key].__args__[0]()
updated_list.append(
_recursive_update_dataclass_from_json_obj(item_instance, item)
)
Expand Down
Loading