Skip to content

Include module name and type in validation error messages #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RohithVangalla1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Include module name and type in validation error messages #823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions opacus/validators/module_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,17 @@ def validate(
IllegalModuleConfigurationError("Model needs to be in training mode")
)
# 2. perform module specific validations for trainable modules.
# TODO: use module name here - it's useful part of error message
for _, sub_module in trainable_modules(module):
for module_name, sub_module in trainable_modules(module):
if type(sub_module) in ModuleValidator.VALIDATORS:
sub_module_validator = ModuleValidator.VALIDATORS[type(sub_module)]
errors.extend(sub_module_validator(sub_module))
sub_errors = sub_module_validator(sub_module)
for err in sub_errors:
# Prepend module name to error message for easier debugging
err.args = (
f"{module_name} ({type(sub_module).__name__}): {err.args[0]}",
*err.args[1:],
)
errors.extend(sub_errors)
# raise/return as needed
if strict and len(errors) > 0:
raise UnsupportedModuleError(errors)
Expand Down