Fix PCRE2 UTF-8 validation errors for Qwen tokenizers#171
Merged
kirklandsign merged 6 commits intomainfrom Feb 4, 2026
Merged
Conversation
- Retry PCRE2 compilation without PCRE2_UTF flag when UTF-8 validation fails - Catch std::regex_error exceptions in StdRegex::find_all() to prevent crashes - Add test for invalid UTF-8 pattern handling Co-authored-by: kirklandsign <107070759+kirklandsign@users.noreply.github.com>
Co-authored-by: kirklandsign <107070759+kirklandsign@users.noreply.github.com>
Co-authored-by: kirklandsign <107070759+kirklandsign@users.noreply.github.com>
Co-authored-by: kirklandsign <107070759+kirklandsign@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with memory management in executorch
Fix PCRE2 UTF-8 validation errors for Qwen tokenizers
Feb 3, 2026
larryliu0820
approved these changes
Feb 4, 2026
larryliu0820
reviewed
Feb 4, 2026
.gitignore
Outdated
Comment on lines
16
to
17
| _codeql_build_dir/ | ||
| _codeql_detected_source_root |
Co-authored-by: kirklandsign <107070759+kirklandsign@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qwen tokenizer patterns contain byte sequences that aren't valid UTF-8, causing PCRE2 compilation to fail with "UTF-8 error: isolated byte with 0x80 bit set". This prevents loading tokenizers for Qwen2.5 and OuteTTS models.
Changes
PCRE2_UTFflagstd::regex_errorinfind_all()to prevent crashes from pattern complexity errorsFallback chain
Pattern compilation now follows: RE2 → PCRE2 (with UTF) → PCRE2 (without UTF) → std::regex
Example
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.