Skip to content

fix: added validation for proposals so they have 2 outcomes #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
metaproph3t merged 3 commits into from
Jun 25, 2025
Merged

fix: added validation for proposals so they have 2 outcomes #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d18b169
fix: added validation for proposals so they have 2 outcomes
Jun 25, 2025
dcba770
fix: testing tests
Jun 25, 2025
c477d38
fix: testing tests v2
Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions programs/autocrat/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,6 @@ pub enum AutocratError {
InsufficientLpTokenBalance,
#[msg("The LP tokens passed in have less liquidity than the DAO's `min_quote_futarchic_liquidity` or `min_base_futachic_liquidity`")]
InsufficientLpTokenLock,
#[msg("Question must have exactly 2 outcomes for binary futarchy")]
QuestionMustBeBinary,
}
6 changes: 6 additions & 0 deletions programs/autocrat/src/instructions/initialize_proposal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@ impl InitializeProposal<'_> {
pub fn validate(&self) -> Result<()> {
let clock = Clock::get()?;

require_eq!(
self.question.num_outcomes(),
2,
AutocratError::QuestionMustBeBinary
);

for amm in [&self.pass_amm, &self.fail_amm] {
// an attacker is able to crank 5 observations before a proposal starts
require!(
Expand Down
Loading