Skip to content

Conversation

@reosarevok
Copy link
Member

Generally bringing some dependencies up to date. See commits for info.

@reosarevok reosarevok added the Refactoring Refactoring-only PRs (eslint fixes etc) label Nov 19, 2025
@reosarevok reosarevok marked this pull request as ready for review November 19, 2025 16:49
@mwiencek
Copy link
Member

mwiencek commented Dec 8, 2025

Looks good, except I'd prefer setting import/enforce-node-protocol-usage to always. I've generally been using those for all new code. The only problem is that Flow doesn't recognize them.

As far as I can tell, we are not using this at all anymore;
we use bin/babel-node instead (and webpack + babel).
While running this, I got a warning:
[@stylistic/eslint-plugin]: You are using deprecated
value(boolean) for "allowTemplateLiterals" in
"quotes", please use "always"/"never" instead.
Changing to the now intended option "avoidEscape"
turned up a bunch of new issues, amended with --fix
See https://github.com/eslint-stylistic/eslint-stylistic/blob/52b2b2ebd1d911c72c42aea7db05a56ea919cdca/packages/eslint-plugin/rules/quotes/README.md

Otherwise, nothing that requires changes.

https://github.com/eslint-stylistic/eslint-stylistic/releases/tag/v5.2.0
https://github.com/eslint-stylistic/eslint-stylistic/releases/tag/v5.2.1
https://github.com/eslint-stylistic/eslint-stylistic/releases/tag/v5.2.2
https://github.com/eslint-stylistic/eslint-stylistic/releases/tag/v5.2.3
indent now wants to change the indents of a bunch of lines,
mostly indenting further where we assign a const after newline;
the changes seem generally cleaner to me than before.

multiline-comment-style seems to have a new bug for cases
where code is surrounded by comments; disabling it for now
in the affected places.

https://github.com/eslint-stylistic/eslint-stylistic/releases/tag/v5.3.0
http://github.com/eslint-stylistic/eslint-stylistic/releases/tag/v5.3.1
Adds new experimental rule list-style. It causes no new
warnings but it mostly seems meant as a condensation of
several existing rules, so for now I'm not activating it.
Eventually (once non-experimental) I expect they
will deprecate some other rules for this one.

https://github.com/eslint-stylistic/eslint-stylistic/releases/tag/v5.5.0
Adds new rule enforce-node-protocol-usage - we mostly
followed the never option, but mwiencek mentioned that
he's been trying to follow the always one in new files,
so I set it to always and let --fix make it consistent.

crypto and readline were missing from flow-typed, so
I am adding them here so Flow is happy.

For some reason, the rule wants to use node punycode,
which is not what we want, so I had to disable eslint
there.

https://github.com/import-js/eslint-plugin-import/releases/tag/v2.32.0
The breaking change for v 16:
"serviceworker globals are now generated from browsers"

https://github.com/sindresorhus/globals/releases/tag/v16.0.0
Copy link
Member

@mwiencek mwiencek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactoring Refactoring-only PRs (eslint fixes etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants