dont skip files that taglib doesnt like#7
Closed
metalheim wants to merge 5 commits into
Closed
Conversation
instead import with empty metadata/audioproperties
new configuration option scanner.importonreaderror. Defaults false to preserve original behaviour
Owner
Author
|
i was mistaken. This is not even required. Navidrome reads .xm retro music files just fine when being told that it is a valid audio format in resources/mime_types.yaml
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of importing nothing, import a file with empty metadata and audioproperties.
This is useful to import music formats that taglib cannot handle. For example retro music files (.mod, .xm, .midi) or music videos.
Description
Currently, file formats that taglib cannot handle are skipped (nothing is imported by scanner).
This PR introduces a new configuration option
scanner.importonreaderrorWhen set to
true, the scanner will import a file that is giving taglib errors anyways (with emtpy metadata).Defaults to
falseto preserve original behaviourRelated Issues
navidrome#2894
navidrome#1929
navidrome#5196
Type of Change
Checklist
Please review and check all that apply:
How to Test
TODO: provide test files