Use less-rails on 2.3.3 branch#130
Open
bibstha wants to merge 2 commits into
Open
Conversation
Collaborator
|
Hello @bibstha. I'm sorry, but I missed this PR. Can you rebase please? I can merge and release after. |
|
@simi i can prepare a new PR to support https://github.com/metaskills/less-rails/releases/tag/v3.0.0. Would you merge it? We use your gem in some of our production apps and have issues upgrading to latest rubies/rails. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of our apps still depend on bootstrap 2 and we no longer put a lot of effort into maintaining it.
However we have to update it to Rails5 according to our internal policy.
Since rails5 require a higher version of less-rails, this PR allows less-rails-bootstrap 2.3.4 to use less-rails 2.8 as in the master branch of less-rails-bootstrap.
Note: This should be merged with tag: v2.3.3 and created a new tag: v2.3.4, not with master