Add CLI for ingesting tabular forecasts and observations into EMOS - #1584
Closed
gavinevans wants to merge 43 commits into
Closed
Add CLI for ingesting tabular forecasts and observations into EMOS#1584gavinevans wants to merge 43 commits into
gavinevans wants to merge 43 commits into
Conversation
…a into iris cubes.
…re not finalised.
… of forecast and observation tables.
… of forecast and observation tables.
…gestion_cli * improver1538_load_parquet: Modify environments in preparation for changes required for ingestion of forecast and observation tables. Extend docstring. Add edit to doc/source/conf.py. Minor edits to load_parquet functionality. Add a load_parquet function with unit tests.
…1538_tabular_ingestion_cli * improver1538_tabular_ingestion_functions: Modify environments in preparation for changes required for ingestion of forecast and observation tables. Modifications to the columns expected within the truth table. Modifications to functions required to support converting tabular data into iris cubes.
…a into iris cubes.
… of forecast and observation tables.
…lar_ingestion_cli * upstream/master: Retain ensemble realization numbers from the raw forecast after reordering (metoppv#1580)
…1538_tabular_ingestion_cli * improver1538_tabular_ingestion_functions: Edits to expect the period column to be a timedelta64 dtype. Modify environments in preparation for changes required for ingestion of forecast and observation tables. Modifications to the columns expected within the truth table. Modifications to functions required to support converting tabular data into iris cubes.
…1538_tabular_ingestion_cli * improver1538_tabular_ingestion_functions: Edits to expect the period column to be a timedelta64 dtype.
…1538_tabular_ingestion_cli * improver1538_tabular_ingestion_functions: Modifications to use assertCubeEqual to ensure the full cubes are compared. Corrections to __init__.py
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #1584 +/- ##
==========================================
+ Coverage 97.98% 98.03% +0.05%
==========================================
Files 107 108 +1
Lines 9613 9829 +216
==========================================
+ Hits 9419 9636 +217
+ Misses 194 193 -1
Continue to review full report at Codecov.
|
gavinevans
changed the title
Contributor
|
Just a note for something to come back to. We will need to filter out a certain percentile set out of the table and the percentiles will be floating point values. This might mean the extraction requires some thought. |
…1538_tabular_ingestion_cli * improver1538_tabular_ingestion_functions: Minor docstring amendment. Sort lists. Correction to csv files. Add missing unit tests. Minor updates to docstrings. Modifications following review comments.
… latitude and longitude at all and replace with those from the forecast.
…1538_tabular_ingestion_cli * improver1538_tabular_ingestion_functions: Further minor docstring edit. Minor extended documentation edits. Modifications to tidy up dataframe preparation. Refinement and addition of tests for column name checking. Extended documentation updates. Extend docstrings. NOT WORKING: Working commit to try to avoid using the truth altitude, latitude and longitude at all and replace with those from the forecast.
Contributor
Author
|
This PR will be superseded by gavinevans#16 once #1582 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1538
Dependent upon #1572, #1582. Note that the changes from these PRs are currently also within this PR. This PR will only be reviewed once PRs on which it depends have been merged. At that point, the diff in this PR will reduce to only a few hundred lines.
Description
This PR builds upon work done in #1582 to add an
estimate_emos_coefficients_from_tableCLI that converts the pandas dataframe into an iris cube (#1582) and passes that iris cube to the existing EMOS functionality.The functionality within this CLI will be extended to support the use of an additional predictor when #1564 is merged.
Files changed in this PR:
Note that this PR does contain an update to acceptance.py to support providing a directory as a known good output in the acceptance tests. This is required for compatibility with a partitioned parquet file.
Further information is available in this comment.
Testing: