Expose chunksize to save - #2410
Closed
cpelley wants to merge 1 commit into
Closed
Conversation
rhattersley
reviewed
Jul 14, 2026
| compression_level: int = 1, | ||
| least_significant_digit: Optional[int] = None, | ||
| fill_value: Optional[float] = None, | ||
| **kwargs, |
There was a problem hiding this comment.
Type checking on most of the arguments, but then adding a **kwargs catch-all? 🤔 As well as undermining the type checking it also leads to inconsistent handling of the arguments to iris.fileformats.netcdf.save.
Contributor
Author
There was a problem hiding this comment.
Thanks Richard 👍
This PR represented 'functional coding notes' during a live call with a user (capturing the intent of their requirements, rather than the likely implementation to meet those requirements). I likely should have done this offline in some way :)
The real PR (though still draft until I get a chance to evaluate testing) is here:
#2412
Thanks for your interest @rhattersley ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #GitHubissuenum
Description
Testing:
CLA