Support multiple interpolation windows in ForecastTrajectoryGapFiller - #2418
Open
gavinevans wants to merge 1 commit into
Open
Support multiple interpolation windows in ForecastTrajectoryGapFiller#2418gavinevans wants to merge 1 commit into
gavinevans wants to merge 1 commit into
Conversation
…windows for difference forecast source pairs. Modify identification of forecast periods for regeneration to avoid identifying more transition points than expected. Add warnings and better support, rather than silently continuing, in the situation where the forecast periods required for regeneration are not available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the Forecast TrajectoryGapFiller plugin and CLI, so that it is possible to use different interpolation windows for different forecast source pairs. This is desirable because a shorter interpolation window might be desirable at nowcast timescales whilst a longer interpolation window might be desirable at longer lead times.
This PR also fixes a couple of edge cases that were noticed in testing:
period_to_sourcesvariable could look something like below where a transition will only be identified where the set of sources changes.{ 3600: {"uk_det", "uk_ens"}, 21600: {"uk_det", "uk_ens"}, 43200: {"uk_ens"}, 86400: {"uk_ens"}, 129600: {"gl_ens"}, 172800: {"gl_ens"}, }Testing: