Warn in Combine plugin for new variable name not matching CF conventions - #2419
Open
mo-robert-purvis wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cube_combiner.pypluginCombineallows for a new name to be given to the variable in the combined cube. It will allow for one that doesn't conform to the CF conventions on variable names (https://cfconventions.org/Data/cf-standard-names/docs/guidelines.html) - allowing a name starting with a digit. An invalid variable name will subsequently be silently modified byiriswithvar_added as a prefix.This change to IMPROVER will add a warning to inform that the variable name is contrary to the CF naming conventions, and that Iris will add a prefix to the name. The
new_namevalue is not modified - simply warned about.The output of this message is as a user warning, e.g.:
UserWarning: improver.api.Combine during execution: The new variable name (10m_ratio_wind_speed_of_gust) does not start with a letter, and so is contrary to the CF convention for variable names. Iris will add 'var_' as a prefix to it.Testing:
Combineplugin and sets anew_nameargument starting with a digit