Skip to content

[FIX] OO-1431 Inactive mail templates should not send mail. #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amh-mw wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[FIX] OO-1431 Inactive mail templates should not send mail. #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions addons/calendar/models/calendar_attendee.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ def _send_mail_to_attendees(self, mail_template, force_send=False):
if not mail_template:
_logger.warning("No template passed to %s notification process. Skipped.", self)
return False
if not mail_template.active:
return False

# get ics file for all meetings
ics_files = notified_attendees.event_id._get_ics_file()
Expand Down
5 changes: 5 additions & 0 deletions addons/calendar/tests/test_event_notifications.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ def test_message_inactive_invite(self):
with self.assertNoNotifications():
self.event.partner_ids = self.partner

def test_message_inactive_template(self):
self.env['mail.template'].search([]).active = False
with self.assertNoNotifications():
self.event.partner_ids = self.partner

def test_message_set_inactive_invite(self):
self.event.active = False
with self.assertNoNotifications():
Expand Down