Skip to content

[IMP] OO-1391 Don't enclose shared favorites in accordion. #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amh-mw wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[IMP] OO-1391 Don't enclose shared favorites in accordion. #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions addons/web/static/src/search/search_bar_menu/search_bar_menu.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,18 +142,9 @@
<t t-if="favoriteItems.length">
<div role="separator" class="dropdown-divider"/>
</t>
<t t-if="sharedFavoritesItems.length > 10">
<AccordionItem class="'o_shared_favorites text-truncate'" description.translate="Shared filters">
<t t-foreach="sharedFavoritesItems" t-as="item" t-key="item.id">
<t t-call="web.SearchBarMenu.FavoriteItem" />
</t>
</AccordionItem>
</t>
<t t-else="">
<t t-foreach="sharedFavoritesItems" t-as="item" t-key="item.id">
<t t-call="web.SearchBarMenu.FavoriteItem" />
</t>
</t>
<div t-if="sharedFavoritesItems.length" role="separator" class="dropdown-divider"/>
<t t-set="currentGroup" t-value="null"/>
<t t-foreach="otherItems" t-as="item" t-key="item.key">
Expand Down
38 changes: 0 additions & 38 deletions addons/web/static/tests/search/search_bar_menu/favorite_menu.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,41 +298,3 @@ test("edit a favorite with a groupby", async () => {
await toggleSearchBarMenu();
expect(`.o_group_by_menu .o_menu_item:not(.o_add_custom_group_menu)`).toHaveCount(0);
});

test("shared favorites are grouped under a dropdown if there are more than 10", async () => {
onRpc("create_or_replace", ({ args, route }) => {
expect.step(route);
const irFilter = args[0];
expect(irFilter.domain).toBe(`[]`);
return 10; // fake serverSideId
});
const irFilters = [];
for (let i = 1; i < 11; i++) {
irFilters.push({
context: "{}",
domain: "[('foo', '=', 'a')]",
id: i,
is_default: false,
name: "My favorite" + i,
sort: "[]",
});
}
await mountWithSearch(SearchBarMenu, {
resModel: "foo",
searchMenuTypes: ["favorite"],
searchViewId: false,
irFilters,
activateFavorite: false,
});
await toggleSearchBarMenu();
expect(".o_favorite_menu .o-dropdown-item").toHaveCount(10);
await toggleSaveFavorite();
await editFavoriteName("My favorite11");
await contains(".o-checkbox:eq(1)").click();
await saveFavorite();
expect.verifySteps(["/web/dataset/call_kw/ir.filters/create_or_replace"]);
expect(".o_favorite_menu .o-dropdown-item").toHaveCount(0);
expect(".o_favorite_menu .o_menu_item:contains(Shared filters)").toHaveCount(1);
await contains(".o_favorite_menu .o_menu_item:contains(Shared filters)").click();
expect(".o_favorite_menu .o-dropdown-item").toHaveCount(11);
});