Skip to content

Factorize only once in smartstart#5

Open
mfalt wants to merge 1 commit intomasterfrom
directsmartstart
Open

Factorize only once in smartstart#5
mfalt wants to merge 1 commit intomasterfrom
directsmartstart

Conversation

@mfalt
Copy link
Copy Markdown
Owner

@mfalt mfalt commented Aug 6, 2019

TODO: Remove some duplicate code, fix copy of Hermetian

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 6, 2019

Codecov Report

Merging #5 into master will decrease coverage by 4.57%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   93.63%   89.05%   -4.58%     
==========================================
  Files           5        5              
  Lines         377      393      +16     
==========================================
- Hits          353      350       -3     
- Misses         24       43      +19
Impacted Files Coverage Δ
src/choleskySpecial.jl 93.87% <100%> (ø) ⬆️
src/boxConstrainedQP.jl 78.41% <100%> (-12.64%) ⬇️
src/quadraticProgram.jl 98.82% <100%> (ø) ⬆️
src/choleskySpecialShifted.jl 92.43% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d6ccd...17d43f6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants