CI: add check+clippy+audit#35
Conversation
|
It seems clippy is not installed on nightly in the CI. |
Ho nice idea, indeed. enforce different jobs to pass in the github UI is ... not optimal 😆 |
check and clippy ensure that the code is warning-free, audit ensures that the dependencies are vulnerability free.
by adding a single `build-results` job which depends on all other jobs we can simplify the setting of required builds in the repository. currently, all builds - including all variations of the build matrix! - need to be manually specified. once this has been merged the settings can be changed to require only this one job (which will fail if any of the other jobs failed). this way it's also easier to add/remove jobs or change the build matrix as it no longer requires changing the settings on the repository. this is inspired by [this discussion on GH][discussion]. [discussion]: https://github.com/orgs/community/discussions/26822
rursprung
force-pushed
the
add-check-and-clippy-to-CI
branch
from
29a4274 to
6c18be7
Compare
good point - i've now changed it to only run for |
|
Looks good to me now ! |
2 participants
see the individual commit messages for further details.
@mgautierfr: i noticed that so far your PR settings do not seem to enforce that the CI actually passes. since you're using a build matrix it's cumbersome to do this manually (you'd have to list all combinations of the matrix and update it every time you change that). i've started using the
build-resultsjob which i've added here in most of my rust repos nowadays and it works fine. once the PR is merged you can just list this one job as being required for PRs to be merged and then you're set.