Ensure that unique (now once) fixture are actually not shared#41
Merged
Conversation
Nothing else to do. A MatrixScope fixture is a fixture with a shared state (through `Duplicate`) not stored in the cache.
`Unique` was error prone as user (and myself) may think that the fixture was unique, and so created only once. Hope that `once` will be better.
Unique fixture must not share a state.
As unique scope fixtures do not share a state, we have to introduce a shared state in `Global` fixture.
mgautierfr
force-pushed
the
unique_is_unique
branch
from
47cdf6f to
ba5d5b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last introduction of two step fixture building was introducing a bug where unique fixture was actually shared across test/fixture's matrix.
This PR: