[2.0.x] Fix never type for dynamic container service IDs - #1016
Merged
Conversation
fix(type): avoid never type for dynamic container service IDs Container get()/has() built their return type by unioning the types of each constant string argument. A variable service ID has none, so the union of zero types collapsed to never — a subtype of everything — triggering entityStoragePropertyAssignment on core-generated proxy classes. Fall back to the declared return type instead. Closes #1012 Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #1014 (70c804d) to 2.0.x. Fixes #1012 for the 2.0.x line.
Clean pick, no conflicts. Full suite, targeted type and rule tests pass on 2.0.x.
🤖 Generated with Claude Code