Fix memory leak and zombie routers in clearTop navigation#1
Open
mhdamirhamza wants to merge 1 commit into
Open
Fix memory leak and zombie routers in clearTop navigation#1mhdamirhamza wants to merge 1 commit into
mhdamirhamza wants to merge 1 commit into
Conversation
Call detachInternal() on intermediate stack entries before removing them from the iterator in clearTop() to ensure correct lifecycle teardown and prevent memory leaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak and zombie routers issue in
StackRouterNavigator.ktduringCLEAR_TOPnavigation. Previously, intermediate stack entries were removed from thenavigationStackiterator usingnavigationIterator.remove()without invokingdetachInternal(). This caused those intermediate routers to remain active as zombie/live children of the host router, leaking views, interactors, and RxJava subscriptions in memory.This contribution fixes the issue by explicitly calling
detachInternal(routerAndState, newState, true)right before the iterator removes the state, ensuring proper lifecycle teardown.Related issue(s):
None (Found via manual source code security audit).
Test plan:
Verified that the correct lifecycle teardown (
willDetachFromHostandonPostDetachFromHost) triggers properly for all bypassed routers whenCLEAR_TOPflag is executed.