fix(inspector-proxy): fix protocol rewrite self-assignment#1
Open
mhdamirhamza wants to merge 1 commit into
Open
fix(inspector-proxy): fix protocol rewrite self-assignment#1mhdamirhamza wants to merge 1 commit into
mhdamirhamza wants to merge 1 commit into
Conversation
Fixed a critical bug in Device.js where debuggerRelativeUrl.protocol was assigned to itself, causing protocol rewrites to fail. Issue Details: Inside #deviceRelativeUrlToDebuggerRelativeUrl(), the protocol rewrite was effectively a no-op because it assigned the property to its own value. This led to issues where HTTPS/HTTP rewrites didn't occur, causing broken source map and script URLs in the DevTools frontend. Fix: Changed the assignment to debuggerRelativeBaseUrl.protocol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a critical bug in Device.js where debuggerRelativeUrl.protocol was assigned to itself, causing protocol rewrites to fail.
Issue Details:
Inside #deviceRelativeUrlToDebuggerRelativeUrl(), the protocol rewrite was effectively a no-op because it assigned the property to its own value. This led to issues where HTTPS/HTTP rewrites didn't occur, causing broken source map and script URLs in the DevTools frontend.
Fix:
Changed the assignment to debuggerRelativeBaseUrl.protocol.