Open
Conversation
Owner
|
What does the first commit fix in the "foo " case? I can't see any difference. Currently the completion doesn't seem to handle files with whitespaces. But checking against And I'm no fan of the vint changes. Replacing It would be cool if you would use one commit per change. It's kind of hard to follow otherwise. And |
blueyed
force-pushed
the
fix-complete_files
branch
from
4c8a524 to
9591a26
Compare
Contributor
Author
|
Changed the vint changes.. for the map expr you can use "'foo'", i.e. double quotes for the outer level. policies:
ProhibitEqualTildeOperator:
enabled: false
ProhibitUnnecessaryDoubleQuote:
enabled: false(although I would prefer to fix them) Will have to revisit this PR / answer your comments, but might take a while. |
blueyed
force-pushed
the
fix-complete_files
branch
from
48d60d8 to
3f36bbf
Compare
It seems like this just confused path with head for completing relative files. With "foo " head contains whitespace at the end, but path does not. This fixes completion of relative files basically.
- handle '~/' correctly: previously is was even matched by the `=~ '^.\/'`, which turned "~/foo" into "./foo" then! - handle relative paths without prefix at the end - fix issues reported by vint (single quotes)
blueyed
force-pushed
the
fix-complete_files
branch
from
3f36bbf to
beaeb9f
Compare
mmrwoods
added a commit
to mmrwoods/vim-grepper
that referenced
this pull request
Apr 20, 2022
- Expand tilde alone to $HOME (same as vim's built in path completion) - Support completion of paths relative to ~/ (taken from PR mhinz#152) This is getting quite messy now, but that's ok, we have some tests! Refactoring can come later, maybe when supporting hidden files/dirs.
mmrwoods
added a commit
to mmrwoods/vim-grepper
that referenced
this pull request
Apr 20, 2022
- Expand tilde alone to $HOME (same as vim's built in path completion) - Support completion of paths relative to ~/ (taken from PR mhinz#152) This is getting quite messy now, but that's ok, we have some tests! Refactoring can come later, maybe when supporting hidden files/dirs.
mmrwoods
added a commit
to mmrwoods/vim-grepper
that referenced
this pull request
May 6, 2022
- Expand tilde alone to $HOME (same as vim's built in path completion) - Support completion of paths relative to ~/ (taken from PR mhinz#152) This is getting quite messy now, but that's ok, we have some tests! Refactoring can come later, maybe when supporting hidden files/dirs.
mmrwoods
added a commit
to mmrwoods/vim-grepper
that referenced
this pull request
May 6, 2022
- Expand tilde alone to $HOME (same as vim's built in path completion) - Support completion of paths relative to ~/ (taken from PR mhinz#152) This is getting quite messy now, but that's ok, we have some tests! Refactoring can come later, maybe when supporting hidden files/dirs.
mmrwoods
added a commit
to mmrwoods/vim-grepper
that referenced
this pull request
May 6, 2022
- Expand tilde alone to $HOME (same as vim's built in path completion) - Support completion of paths relative to ~/ (taken from PR mhinz#152) This is getting quite messy now, but that's ok, we have some tests! Refactoring can come later, maybe when supporting hidden files/dirs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see the commits for details.