Push context all the way to csc resolution#1
Open
xerootg wants to merge 2 commits intomhutch:mainfrom
Open
Conversation
…csc used by MSBuild can be used
Author
|
@mhutch do you have any thoughts on this change? |
Owner
|
@xerootg sorry I haven't had time to look at this recently. I'm definitely on board with the feature, I just need to think about how I would want to surface it in the public API. I've had ideas for a while to separate out the execution runtime, compilation target runtime, and the compiler toolchain, and this would obviously intersect with that. |
Author
|
I might have some time to work on this coming up, do you have a specific pattern your looking for? Seems kinda tricky to determine this detail but also was tricky to snake it through. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I am retargeting this from mono/t4, I need a way to use a more modern csc for framework based msbuild uses, specifically for a more modern c# version. This might not be the most perfect solution for piping the csc.exe path from the build task to the RuntimeInfo class, let me know what you'd prefer if not. re: mono#198