fix: normalize injection tokens to standard Angular pattern#70
Merged
Conversation
- Replace function-based tokens with standard InjectionToken instances - Update RX_STATEFUL_CONFIG to use direct token instead of function - Update RX_STATEFUL_CLIENT_CONFIG to use direct token instead of function - Update provider functions to use new tokens directly
- Verify token injection works correctly with new pattern - Test optional injection returns null when not provided
- Document breaking change in CHANGELOG - Provide clear migration instructions - Note that most users won't be affected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Fixes #54
Changes Made
1. Token Definition Updates
2. Provider Updates
3. Testing
Breaking Change
This is a breaking change for users directly injecting the tokens (rare case).
Migration Required
If you were using the tokens directly:
Note: Most users only use provideRxStatefulConfig() or rxRequest() and will not need any changes.
Testing Performed
Checklist