fix: improve rxRequest API ergonomics with function overloads#71
Closed
michaelbe812 wants to merge 1 commit into
Closed
fix: improve rxRequest API ergonomics with function overloads#71michaelbe812 wants to merge 1 commit into
michaelbe812 wants to merge 1 commit into
Conversation
- Add function overloads for better type safety when no trigger is provided - Remove unsafe 'undefined as A' casting from implementation - Separate types for with-trigger and without-trigger cases - Add comprehensive tests for both overload scenarios - Maintain full backward compatibility with existing code Fixes #53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Fixes #53
Changes Made
API Improvements
Type Safety
Testing
Breaking Changes
None - this change is fully backward compatible. It only adds function overloads without removing any existing functionality.
Testing Checklist