refactor: consolidate initial value derivation logic#72
Merged
Conversation
- Replace inline deriveInitialValue implementation with calcStartValueForRefresh utility - Eliminates code duplication while maintaining same behavior - Improves maintainability with single source of truth for initial value logic - Preserves existing API and all tests continue to pass Fixes #51
michaelbe812
force-pushed
the
fix/consolidate-initial-value-logic
branch
from
September 16, 2025 13:13
10fabb2 to
a4f2ae0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The codebase had two separate implementations for determining initial values during refresh operations:
calcStartValueForRefreshutility function (with tests but unused)deriveInitialValueinline function in create-state.ts (no direct tests)This duplication created maintenance burden and risk of inconsistent behavior.
Solution
deriveInitialValueto internally use the existingcalcStartValueForRefreshutilityderiveInitialValueis now a thin wrapper that creates an RxJS operator using the centralized logicChanges
calcStartValueForRefreshin create-state.tsderiveInitialValueto delegate tocalcStartValueForRefreshTesting
Benefits
calcStartValueForRefresh)Fixes #51