fix: remove redundant refetchFn() call and fragile BehaviorSubject handling#73
Merged
Merged
Conversation
- Eliminate double-call to strategy.refetchFn() in mergeRefetchStrategies - Remove fragile instanceof BehaviorSubject check - Let individual strategies handle their own skip(1) logic - Add comprehensive tests for single-call behavior and BehaviorSubject handling Fixes #48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strategy.refetchFn()inmergeRefetchStrategiesfunctioninstanceof BehaviorSubjectcheck that doesn't work reliably with piped observablesskip(1)logicContext
This PR addresses issue #48 which identified performance and logic issues in the
mergeRefetchStrategiesfunction.Problems Fixed
Redundant Function Calls: The function was calling
strategy.refetchFn()twice - once for the pipe operation and once for the BehaviorSubject check. This was wasteful and could cause side effects with cold streams.Fragile BehaviorSubject Detection: The
instanceof BehaviorSubjectcheck was unreliable and created unnecessary coupling between the merge logic and individual strategies.Changes Made
mergeRefetchStrategiesto callrefetchFn()only once per strategyTesting
refetchFn()is called exactly once per strategyBenefits
Fixes #48