fix: remove unsafe type casting in errorMappingFn#77
Closed
michaelbe812 wants to merge 1 commit into
Closed
Conversation
- Changed errorMappingFn return type from unknown to E for type consistency - Removed unsafe 'as any' cast in handleError function - Maintains type safety throughout error handling pipeline Fixes #46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errorMappingFnthat required unsafe type castingChanges
errorMappingFnreturn type fromunknowntoEfor type consistencyas anycast inhandleErrorfunctionProblem
The
errorMappingFnwas typed to returnunknown, but the error field inRxStatefulWithErrorexpects typeE. This mismatch forced the use of unsafeas anycasting in thehandleErrorfunction.Solution
Updated the type signature to maintain consistency:
errorMappingFn?: (error: E) => EThis ensures the error type remains consistent throughout the pipeline while removing the need for unsafe casting.
Testing
Fixes #46