Conversation
Owner
|
Blocking correctness issue: the worked example is no longer copy-pasteable against current
directories:
- examplesfails configuration validation. Each entry must carry stable source identity, for example: directories:
- id: aip-bundled-examples-v0.5
root: examples
stable_target_identity: urn:aip:logical-root:bundled-examplesPlease rebase/update the example to match the current root |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
What does this change?
Adds a complete, commented
config.yamlexample todocs/configuration.md, based on the repository's current root configuration. The example keeps all existing sections together in one copy-pasteable block and adds concise comments explaining what each section controls.It also reiterates that
NEO4J_USER,NEO4J_PASSWORD,OPENAI_API_KEY, and the optionalNEO4J_URIoverride belong in the environment rather thanconfig.yaml.Validation
git diff --check✅uv run ruff check .✅uv run ruff format --check .✅uv run pytest tests/unit: 1177 passed; 1 unrelated local Windows byte-hash provenance test failed (test_quarkus_openapi_provenance.py)Checklist
If this adds or changes an adapter
Not applicable.