FS-116: coordinated DXF drawing packages#7
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad98f879f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| bearing: finite(state.soilBearing, 150).toFixed(0) | ||
| }; | ||
| }) | ||
| : getBaseReactionRows().map(row => ({ |
There was a problem hiding this comment.
Scope base reaction rows to the foundation floor
When exporting in base-reactions-only mode while an upper floor is selected, this unscoped getBaseReactionRows() call reads state.floors[state.currentFloorIndex] and filters through isFoundationColumnForPlan, so columns deleted or inactive on the selected story can be omitted from the BASE REACTION SCHEDULE even though the foundation/base reaction plan is drawn for state.floors[0]. The schedule should be generated under the same foundation-floor context used by drawFoundationPlanPackage.
Useful? React with 👍 / 👎.
What changed
Why
The former exporter skipped floors, cantilevers, foundation content, schedules, and BOQ data and bypassed corrected floor-aware geometry. Browser URL cleanup could also race the download.
Validation
node v3/tools/check-fs.js --no-browsernode v3/tools/check-fs.jsFutolStructure_2026-7-03 - Olango.fstrScope
This remains preliminary drafting/quantity output. It does not claim final design, BBS, or permit-ready documents.