fix(plugin-meetings): prevent LLM connection from being permanently killed#3
Closed
mickelr wants to merge 1 commit into
Closed
fix(plugin-meetings): prevent LLM connection from being permanently killed#3mickelr wants to merge 1 commit into
mickelr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
updateLLMConnection()disconnects the shared LLM singleton (code 3050, permanent) before validating whether reconnection is feasible. This causes permanent LLM loss in two scenarios:Unjoined meeting triggers disconnect - An incoming CALL creates a new meeting object that calls
updateLLMConnection(). SinceisJoined()is false on the new meeting, it disconnects the webinar LLM but never reconnects.datachannelUrl cleared by locus.difference - A locus delta clears
datachannelUrl. The method disconnects the LLM, thenregisterAndConnect()silently bails out becausedatachannelUrlis null.Fix
Add a guard before
cleanupLLMConneciton()that validates reconnection is feasible (isJoined,url, anddataChannelUrlmust all be truthy). If reconnection is not possible, the existing LLM connection is preserved.Testing