Error Surfacing

[SteveMicroNova]

What does this change intend to accomplish?

Surface backend errors to users better

Also mitigate some minor issues that required surfacing

Checklist

• Have you tested your changes and ensured they work?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• If applicable, have you updated the documentation/manual?
• If applicable, have you updated the CHANGELOG?
• Does your submission pass linting & tests? You can test on localhost using ./scripts/test
• Have you written new tests for your core features/changes, as applicable?
• If this is a UI change, have you tested it across multiple browser platforms on both desktop and mobile?

[SteveMicroNova]

This pathing might need some work. It made more sense when I had multiple alert endpoints being added here but I found 2/3 of the endpoints didn't make sense as I kept devving on this

[linknum23]

Having only a single endpoint for this is useful since it reduces the scope on this. I wish we had a place for odds and ends like this that don't focus on the actual functionality of the unit.

[linknum23]

Since it is only exposed via api/info does it make sense to be there?

Maybe /api/info/hide-alerts or /api/info/alerts/hide ?

[linknum23]

I'm not sold on any of those options tho.

[SteveMicroNova]

I wish we had a place for odds and ends like this that don't focus on the actual functionality of the unit.

It would be trivial to add a api-utils.py or something similar that uses the same FastAPI instance without having it in the same file as the primary functionality if that's what you mean

Also for the routing opinions, I like /api/info/alerts/hide because I do see a world where we might want a /api/info/alerts/add endpoint, the main case being if the frontend finds an error that should become global to all users, or a world where we might want /api/info/alerts as a GET request to return just that portion of the info block (this could be fairly useful to raise these issues to home assistant's notification scheme, for example)

[SteveMicroNova]

The MUI alert component that we use has a "severity" property that has 4 possible values - error, success, warning, and info. I have had no particular use for warning and info thus far, so I flattened it into just success or error. Within that, I generally only needed error so I had it be a store_true arg for whether it shows success or fail, I've upgraded that with full granularity to future proof these changes.

Luckily the other two AlertBar style components we use don't have the same controls so I didn't need to upkeep those for full feature parity in this PR

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 84.44444% with 14 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (VersionWarning@16ea23c). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
amplipi/utils.py	81.39%	8 Missing ⚠️
amplipi/rt.py	25.00%	6 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@                Coverage Diff                @@
##             VersionWarning    #1091   +/-   ##
=================================================
  Coverage                  ?   50.73%           
=================================================
  Files                     ?       41           
  Lines                     ?     7478           
  Branches                  ?        0           
=================================================
  Hits                      ?     3794           
  Misses                    ?     3684           
  Partials                  ?        0           

Flag	Coverage Δ
unittests	50.73% <84.44%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[SteveMicroNova]

To record a conversation we've had in the office:
We'd like to run this for a few days and see if we trigger this message on anything. It seems fine so far, but directing people to email us when they don't really need to could be needlessly annoying for everyone

[SteveMicroNova]

After 24 hours of testing, this is looking good. I'm going to keep my automated testing script going while I'm on vacation next week and I suspect that once I'm back on the 15th this will be good to merge.