Run LMS stream processes in their own process group#1096
Open
stamateviorel wants to merge 1 commit into
Open
Conversation
disconnect() falls back to os.killpg(self.proc.pid, SIGKILL), but the spawned process was never made a process-group leader, so proc.pid is not a valid pgid: the killpg either fails or signals the parent's whole group. Start both squeezelite and the metadata reader with preexec_fn=os.setpgrp so each owns its group, kill via os.killpg(os.getpgid(pid)) on the real group, and tolerate ProcessLookupError when the process already exited. Signed-off-by: Stamate Viorel <stamate.viorel@gmail.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change intend to accomplish?
LMS.disconnect()falls back toos.killpg(self.proc.pid, SIGKILL), but the spawned squeezelite/metadata processes were never made process-group leaders, soproc.pidis not a valid pgid — the killpg either fails or signals the parent's group. This starts both children withpreexec_fn=os.setpgrpso each owns its own group, kills viaos.killpg(os.getpgid(pid)), and toleratesProcessLookupErrorwhen the process already exited (previously an exception escaped during stream teardown).Running in production on our unit; stream stop/reassign no longer leaves orphaned squeezelite processes behind.
Checklist
python -m py_compileclean; happy to fix anything CI flags)