Skip to content

Make Inputs Optional#60

Open
vlilanl wants to merge 6 commits into
masterfrom
make_inputs_optional
Open

Make Inputs Optional#60
vlilanl wants to merge 6 commits into
masterfrom
make_inputs_optional

Conversation

@vlilanl

@vlilanl vlilanl commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

Updates

  • Make inputs to rqcfilter optional

    ReadsQC/rqcfilter.wdl

    Lines 7 to 9 in c66e3b2

    Array[String]? input_files
    Array[String]? input_fq1
    Array[String]? input_fq2

Testing

Successfully tested locally

JAWs runs:

  • 148455: Interleaved
{
  "rqcfilter.input_files": [
    "https://portal.nersc.gov/project/m3408//test_data/smalltest.int.fastq.gz"
  ],
  "rqcfilter.proj": "nmdc:xxxxxxx",
  "rqcfilter.interleaved": true,
  "rqcfilter.shortRead": true
}
  • 148468: Paired
{
    "rqcfilter.input_fq1": [
      "https://portal.nersc.gov/project/m3408//test_data/smalltest.R1.fastq.gz"
    ],
    "rqcfilter.input_fq2": [
      "https://portal.nersc.gov/project/m3408//test_data/smalltest.R2.fastq.gz"
    ],
    "rqcfilter.proj": "nmdc:xxxxxxx",
    "rqcfilter.interleaved": false,
    "rqcfilter.shortRead": true
}

@vlilanl vlilanl requested review from aclum and jasmynp November 13, 2025 21:45
@aclum

aclum commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

@vlilanl would you please resolve the merge conflicts?

@aclum

aclum commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

The jaws runs look good.

Comment thread input.json Outdated

@aclum aclum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is all the work @chienchi did to add support for ncbi accessions removed?

@vlilanl vlilanl force-pushed the make_inputs_optional branch from d248400 to 4ddb014 Compare November 19, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants