Remove trimreaddescription from reformat.sh command in shortReadsqc.wdl#79
Merged
Conversation
aclum
reviewed
Jun 26, 2026
aclum
reviewed
Jun 26, 2026
Co-authored-by: aclum <aclum@users.noreply.github.com>
aclum
reviewed
Jun 26, 2026
aclum
reviewed
Jun 26, 2026
aclum
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Action:
Remove
trimreaddescription=tfromreformat.shcommand in thestage_interleavetask ofshortReadsqc.wdl(introduced in SRA PR #55 (line, ReadsQC v1.0.20, 11/3/25)).Issue:
The parameter is removing pair information from headers (example: header should be @NB551228:6:H7FFKBGX5:4:23602:17332:3792 1:N:0:CTGAAGCT+AGGCTATA but instead @NB551228:6:H7FFKBGX5:4:23602:17332:3792) which is causing parsing errors.
Direct test passed:
local on cromwell via
/global/cfs/cdirs/m3408/www/test_data/smalltest.R1.fastq.gzand/global/cfs/cdirs/m3408/www/test_data/smalltest.R2.fastq.gz. Output headers onfiltered.fastq.gzcontain pair information (ex @NS500756:11:H7FHCBGXH:1:11101:5478:9880 1:N:0:AGCGAGAT+GATACTGG).Impact:
Only non-interleaved (paired) data goes through the impacted
stage_interleavetask. TheReads QC Interleaveworkflow inworkflows.yamlwas still using theinterleave_rqcfilter.wdlinstead ofrqcfilter.wdl(and thereforeshortReadsqc.wdl) until PR microbiomedata/nmdc_automation#688, at which point the ReadsQC version was also updated to v1.0.22. This means that only paired ReadsQC records run under v1.0.22 on (from ~4/2026 on) are affected.Assessment of existing records:
The below mongo query was used to count the number of paired ReadsQC records run under each version number after 10/1/2025. Results pasted below, indicating only 13 records in affected version.
Resolution of problematic records in mongo:
recent_noninterleaved_RQC.json
MongoDB workflows query
[
{
'$match': {
'type': 'nmdc:ReadQcAnalysis',
'ended_at_time': {
'$gte': '2025-10-01T00:00:00.000000+00:00'
},
'processing_institution': 'NMDC'
}
}, {
'$lookup': {
'from': 'data_object_set',
'localField': 'has_input',
'foreignField': 'id',
'as': 'input_do_set',
'pipeline': [
{
'$match': {
'data_object_type': {
'$in': [
'Metagenome Raw Read 2', 'Metagenome Raw Read 1'
]
}
}
}
]
}
}, {
'$match': {
'$expr': {
'$gte': [
{
'$size': '$input_do_set'
}, 2
]
}
}
}, {
'$group': {
'_id': '$version',
'count': {
'$sum': 1
},
'details': {
'$push': '$$ROOT'
}
}
}
]