Skip to content

Make onSelect works also for object keys#101

Open
andres-artunduaga wants to merge 4 commits intomicrolinkhq:masterfrom
andres-artunduaga:issue-82
Open

Make onSelect works also for object keys#101
andres-artunduaga wants to merge 4 commits intomicrolinkhq:masterfrom
andres-artunduaga:issue-82

Conversation

@andres-artunduaga
Copy link

Thanks for reviewing this.

Sending code to cover #82

1. Key Click Selection Behavior

  • Added key-click selection support so clicking object or array keys triggers onSelect, not only value clicks.
  • Applied this behavior consistently across ArrayGroup, JsonObject, ObjectName, and VariableEditor.
  • Added unit tests to cover key-click selection paths.

2. Lint and Test Cleanup

  • Applied style and lint compliance fixes required by pre-commit checks.
  • Cleaned naming, equality checks, handler references, and unused code paths.
  • Updated related tests to keep formatting and fixtures consistent with lint rules.

3. Unit Test Assertion Follow-up

  • Fixed one JsonObject unit test assertion for expanded icon count after test fixture normalization.
  • Confirmed unit tests pass after this adjustment.

@vercel
Copy link

vercel bot commented Feb 27, 2026

@andres-artunduaga is attempting to deploy a commit to the Microlink Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Feb 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-json-view Ready Ready Preview, Comment Feb 28, 2026 9:05pm

Request Review

@Kikobeats
Copy link
Member

@andres-artunduaga thanks, can you add it as part of the demo? 🙏

@Kikobeats
Copy link
Member

@cursor review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants