long, double and boolean support for observations #234#238
Open
nikoncode wants to merge 2 commits into
Open
Conversation
Contributor
|
I've merged the original PR (thanks for your contribution!). Can you take the TypedKeyValue and move it to micrometer-commons and write tests for various use-cases? I guess obviously instead of applying it for the span we would need to return sth like |
|
If you would like us to look at this PR, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@marcingrzejszczak could you please take a look on eb11083? If we will find consensus on this, I will include fixed version in #235.
Probably this change should be in micrometer-common, but I feel that KeyValue object has wide semantic and custom types might not be applicable for metrics tag for example, that's why I put this in tracing and asking your advice.