[Bug]: Support unlimited decimal places for Quantity and Unit Price and five for VAT % for XRechnung and ZUGFeRD#29754
Open
miljance wants to merge 7 commits intomicrosoft:mainfrom
Open
Conversation
… decimal places for VAT %
djukicmilica
previously approved these changes
Feb 25, 2026
djukicmilica
previously approved these changes
Feb 25, 2026
pri-kise
suggested changes
Feb 25, 2026
Apps/DE/EDocumentDE/app/src/XRechnung/ExportXRechnungDocument.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/DE/EDocumentDE/app/src/ZUGFeRD/ExportZUGFeRDDocument.Codeunit.al
Outdated
Show resolved
Hide resolved
JesperSchulz
added
Finance
Contributor
|
Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed. |
Contributor
|
Looks like maybe you forgot to refactor a few lines? At least this code doesn't compile: |
AndersLarsenMicrosoft
previously approved these changes
Feb 25, 2026
Contributor
Author
|
@JesperSchulz I need to rebase on main obviously. The code compiles but not with the latest main. |
…nto DEQuantityDecimalPlacesForEDocs
miljance
dismissed stale reviews from AndersLarsenMicrosoft and djukicmilica
via
c985547
Contributor
Author
|
The main branch has been merged and tests fixed in order to support Service Documents |
Contributor
Sorry, just got back from vacation and simply tried to throw as much code into the build pipeline as I could. Didn't really look much deeper into states of PRs. Thanks for fixing. Let's get this in. |
…nto DEQuantityDecimalPlacesForEDocs # Conflicts: # Apps/DE/EDocumentDE/test/src/XRechnungXMLDocumentTests.Codeunit.al
miljance
force-pushed
the
DEQuantityDecimalPlacesForEDocs
branch
3 times, most recently
from
a730f26 to
fb6cea7
Compare
miljance
force-pushed
the
DEQuantityDecimalPlacesForEDocs
branch
from
fb6cea7 to
1e21a98
Compare
Contributor
Author
|
@JesperSchulz merged the newly synced main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates the XRechnung and ZUGFeRD document export logic to comply with EN 16931 by exporting quantity and unit price fields with unlimited precision and VAT percentages with up to five decimal places. It also updates related test code to ensure consistency and accuracy with the new formatting logic.
Work Item(s)
Fixes #29745
AB#622989