Add cloud-aware endpoints and harden GCC blueprint setup - #478
Open
Rick Brighenti (rbrighenti) wants to merge 14 commits into
Open
Rick Brighenti (rbrighenti) wants to merge 14 commits into
Rick Brighenti (rbrighenti) wants to merge 14 commits into
Conversation
Normalize cloud keys for environment overrides and route consent/token/Graph URL generation through cloud-aware helpers so arbitrary cloud names can be configured without code changes Make client-credential token authority cloud-aware
Rick Brighenti (rbrighenti)
force-pushed
the
feature/cloud-agnostic-endpoints
branch
from
July 24, 2026 16:09
84723d1 to
c0d736c
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- InteractiveGraphAuthService: append /v1.0 to the cloud-specific Graph BaseUrl so overriding RequestAdapter.BaseUrl doesn't drop the API version segment and 404 every request; add regression test. - BootstrapConfigResolver: pass the caller's CancellationToken into the 'az cloud show' invocation so bootstrap can be cancelled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Rick Brighenti (rbrighenti)
September 2, 2026 12:06
View session
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Select the cloud-specific Observability resource and fail safely when blueprint discovery or Graph authorization is inconclusive. Refresh Graph tokens after client app permission changes and preserve the configured blueprint when duplicate display names exist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Rick Brighenti (rbrighenti)
September 2, 2026 16:43
View session
Use service-principal IDs for direct grant queries and distinguish inherited consent from empty or unreadable results. Handle invalid endpoint and manifest values safely, and fail registration-only commands when registration fails. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Rick Brighenti (rbrighenti)
September 9, 2026 13:30
View session
Preserve cloud-aware routing alongside the BYO MCP device-code flow. Partition Graph token caches by authority and validate blueprint lookup rows without losing the stored blueprint. Add regression coverage and clarify explicit GCC endpoint configuration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Rick Brighenti (rbrighenti)
September 25, 2026 14:46
View session
Apply the discovery HTTPS URL contract to explicit create/delete overrides before token acquisition, preserving valid custom paths and independent override precedence. Add regression tests for unsafe URL components and normalization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Rick Brighenti (rbrighenti)
requested review from
Copilot and
jaganp (jaganp-microsoft)
September 25, 2026 15:02
Copilot started reviewing on behalf of
Rick Brighenti (rbrighenti)
September 25, 2026 15:02
View session
Preserve the requested display-name-first single-result recovery behavior. Warn with stored and selected object IDs before setup persists the replacement; keep ambiguous and malformed lookups fail-closed. Document the requirement and cover mismatch, matching/no stored ID, and ambiguous results. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Rick Brighenti (rbrighenti)
September 25, 2026 15:18
View session
Resolve the Observability resource inside existing cloud validation so AzureUSGovernment returns false with actionable guidance before Graph configuration or state writes. Cover all, identity and licenses runner modes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Rick Brighenti (rbrighenti)
September 25, 2026 15:51
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds cloud-aware Microsoft Graph, OAuth authority, and Agent 365 Tools routing, with GCC Moderate validation for ordinary blueprint agents. Commercial endpoints remain the defaults; configurable endpoints and resource mappings do not imply certification of every government cloud.
main, including the BYO MCP device-code improvements, without rewriting branch history.Configuration
For the GCC Moderate scenario exercised here:
GCC Moderate uses the default Graph and authority hosts. The environment name alone does not switch Agent 365 discovery away from the commercial service. Other environments can supply
graphBaseUrl/authorityHostin config or higher-precedenceA365_GRAPH_BASE_URL_{ENV}/A365_AUTHORITY_HOST_{ENV}variables. Graph/authority overrides must be HTTPS origins; environment suffixes are normalized, e.g.gcc-highbecomesGCC_HIGH.The CLI architecture documentation and Unreleased notes describe the behavior.
Validation evidence
Live results below were obtained on
a18beb7de6before this PR refresh. They are not a claim that the newly merged revision has already completed its live retest.ListSampleProducts, returningPhone, Tablet, LaptopwithisError:false.main; assertions were not weakened. Local execution uses .NET 10 roll-forward for net8 targets, not native .NET 8 coverage.