Enable portal-only admin consent for bulk onboarding - #502
Walter Luna (walterluna) wants to merge 3 commits into
Conversation
Declare application roles and delegated scopes with -SkipGrant so administrators can grant consent in Entra without running the script. - Preserve existing API permissions and avoid duplicate declarations - Report declared permissions, consent failures, and portal links - Add regression coverage for permission merging and idempotency
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Resolve merge conflicts and add execution-level coverage for skip-grant behavior.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Enables portal-only admin consent for bulk onboarding by declaring permissions and reporting Entra consent links.
Changes:
- Adds permission merging and idempotency handling.
- Adds
-SkipGrantbehavior and consent reporting. - Adds regression coverage for permission declarations.
| File | Summary |
|---|---|
scripts/bulk-agent-registration/New-A365AutomationApp.ps1 |
Implements permission declaration and consent reporting; unresolved merge conflicts prevent parsing. |
scripts/bulk-agent-registration/tests/PermissionDeclaration.Tests.ps1 |
Tests permission merging, but lacks execution-level coverage for -SkipGrant behavior. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved issues remain in WhatIf reporting, duplicate reconciliation, and consent-status accuracy.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (3)
Resolved since last review (1)
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Resolve partial permission reporting and add the required release note; test organization also needs improvement.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
Declare application roles and delegated scopes with -SkipGrant so administrators can grant consent in Entra without running the script.