Skip to content

Add BCAL package version controls - #969

Merged
martinsrui-msft merged 1 commit into
mainfrom
martinsrui-bcal-version-controls
Oct 13, 2026
Merged

martinsrui-msft merged 1 commit into
mainfrom
martinsrui-bcal-version-controls

Conversation

@martinsrui-msft

@martinsrui-msft martinsrui-msft commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • add a reusable authenticated BCal installer with latest-prerelease and exact pinned modes, strict input validation, stable retries, and structured installed-version verification
  • discover the actual global BCal NuGet tool version before evaluation, verify --bcal-version / BCAL_PACKAGE_VERSION, and preserve the observed version in raw outcomes
  • add per-matrix workflow version controls, focused package-version documentation, and parser/installer/workflow regression coverage

Stack

Validation

  • 141 focused version/parser, PowerShell installer, workflow/action, CLI, panel, and agent-version result tests passed after rebasing directly onto Enable BCAL gold and challenge dataset panels #967
  • Ruff check/format, targeted strict ty, applicable pre-commit hooks, and changed-YAML parsing passed
  • committed diff contains exactly the 11 version-control-required files

@martinsrui-msft
martinsrui-msft added this pull request to stack #970 October 12, 2026 13:49
@github-code-quality

github-code-quality Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: Python

Python / code-coverage/pytest

The overall line coverage in commit f1f4cd8 in the martinsrui-bcal-vers... branch is 88%. The line coverage in commit 52afb99 in the main branch is 87%.

Show a line coverage summary of the most impacted files.
File main 52afb99 martinsrui-bcal-vers... f1f4cd8 +/-
src/bcbench/com...nds/evaluate.py 77% 79% +2%
src/bcbench/age...bcal/version.py 0% 100% +100%

Updated October 13, 2026 09:08 UTC

@martinsrui-msft
martinsrui-msft force-pushed the martinsrui-bcal-version-controls branch from 8ddf124 to d20ffec Compare October 12, 2026 14:07
@martinsrui-msft
martinsrui-msft removed this pull request from stack #970 October 12, 2026 14:09
@martinsrui-msft
martinsrui-msft changed the base branch from martinsrui-bcal-multiturn to martinsrui-bcal-single-turn-panels October 12, 2026 14:10
@martinsrui-msft
martinsrui-msft added this pull request to stack #971 October 12, 2026 14:10
@gggdttt

Wenjie Fan (gggdttt) commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator
  1. Valid version pins can fail the version check. NuGet normalizes versions: 1.2.3+build.10 and 1.2.3.0 are reported as 1.2.3 by dotnet tool list. The string comparisons in Install-BCalTool.ps1 and verify_bcal_version() reject these even when the correct package is installed. Please compare using NuGet version rules and add tests for these cases.

  2. The checked version may not belong to the executable we run. Version discovery checks the default global tool installation, but the agent finds bcal through PATH. If another BCAL installation comes first on PATH, the check can pass while we run a different version and record the wrong agent_version. Please use the same verified installation for both discovery and execution, or reject a path mismatch.

  3. A mixed-version run is shown as a single-version run. Each matrix job installs the latest package separately, so a new package published during a run can produce results from different versions. The raw results keep those versions, but the summary and display only use the first result's version. Please show all versions or clearly mark the run as mixed, rather than label the whole run with the first version.

@martinsrui-msft
martinsrui-msft force-pushed the martinsrui-bcal-version-controls branch from d20ffec to 91399dd Compare October 13, 2026 09:06
Base automatically changed from martinsrui-bcal-single-turn-panels to main October 13, 2026 09:06
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@martinsrui-msft
martinsrui-msft dismissed Wenjie Fan (gggdttt)’s stale review October 13, 2026 09:06

The merge-base changed after approval.

@martinsrui-msft
martinsrui-msft force-pushed the martinsrui-bcal-version-controls branch from 91399dd to f1f4cd8 Compare October 13, 2026 09:06
@martinsrui-msft
martinsrui-msft merged commit 1b36165 into main Oct 13, 2026
17 checks passed
@martinsrui-msft
martinsrui-msft deleted the martinsrui-bcal-version-controls branch October 13, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants