Skip to content

Restore deterministic review fixture coverage - #202

Merged
Jesper Schulz-Wedde (JesperSchulz) merged 1 commit into
mainfrom
jesperschulz-restore-review-fixture-coverage
Sep 29, 2026
Merged

Jesper Schulz-Wedde (JesperSchulz) merged 1 commit into
mainfrom
jesperschulz-restore-review-fixture-coverage

Conversation

@JesperSchulz

Copy link
Copy Markdown
Contributor

Summary

Registered articles

  • data-modeling: code-must-not-change-workdate, pictures-must-use-media-not-blob, table-design-must-match-bc-table-type-conventions
  • error-handling: defensive-vs-offensive-code-must-match-blast-radius, log-writes-must-survive-rollback
  • performance: al-methods-limited-during-write-transactions, avoid-user-prompts-inside-transactions
  • security: exposed-objects-must-be-in-a-permission-set
  • style: al-comments-must-not-restate-what-code-already-shows, pages-must-not-contain-business-logic
  • testing: asserterror-needs-expectederror-and-code, bcpt-scenarios-must-be-app-specific, commit-shared-test-fixture-inside-lazy-initialize, given-blocks-must-cover-full-precondition-chain, table-relation-test-exclude-known-invalid-relations-via-event, test-feature-scenario-tags, test-one-when-per-test, transactionmodel-attribute-governs-test-transactions, ui-test-codeunit-naming, use-assert-isfalse-not-asserterror-for-boolean-checks
  • ui: page-design-must-match-bc-page-type-conventions
  • upgrade: upgrade-tag-logic-must-not-nest-deeply
  • web-services: api-page-least-privilege-write-access

Retrieval metadata

  • al-comments-must-not-restate-what-code-already-shows: add credit-memo-routing for the neutralized clean control whose comments are intentionally stripped
  • pages-must-not-contain-business-logic: add the high-signal rec-modify anti-pattern cue
  • test-feature-scenario-tags: add subtype-test, matching every changed AL test codeunit

Existing leaf skills already contain explicit high-signal routing rules for these articles, so no broader skill-routing changes were needed.

Validation

  • comprehensive synthetic changed-path gate: 69 paths / 23 articles; 198 cases; 99/321 paired articles selected; passed with zero waivers
  • final-diff changed-path gate: passed; 198 cases; 99/321 paired articles selected
  • frontmatter/structure: 0 errors; 2 pre-existing warnings on untouched keyword-heavy convention articles
  • knowledge index and bounded retrieval: 389 articles and 665 samples; passed
  • skill index and schemas: passed; all 19 review leaves preserved
  • review contract: 8 predicate cases plus executable acceptance cases; passed
  • git diff --check: passed

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@JesperSchulz
Jesper Schulz-Wedde (JesperSchulz) merged commit 164b27d into main Sep 29, 2026
7 checks passed
Michael Dieringer (MichaelDieringer) added a commit to Curabis/BCQuality that referenced this pull request Sep 29, 2026
…crosoft#198, microsoft#202) into document-distribution-batch

Resolve evaluation/review-fixtures.json semantically: data-modeling
articles list is the union of main's list and this PR's nine articles;
everything else is taken from main unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant