fix: Added deployment tags and dev container fix and PrincipleId param fix#124
Merged
Prajwal-Microsoft merged 2 commits intomicrosoft:mainfrom Apr 2, 2026
Merged
Conversation
Rafi-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
dgp10801
as code owners
Prajwal-Microsoft
approved these changes
Apr 2, 2026
|
🎉 This PR is included in version 1.2.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces improvements to the infrastructure provisioning process, focusing on better parameter defaults, enhanced tagging for resource groups, and improved environment compatibility for scripts. The main themes are improved automation, traceability, and cross-platform support.
Parameter and Tagging Improvements:
principalIdparameter inmain.bicepto use the deployer's object ID, reducing the need for manual input and potential errors.createdByparameter inmain.bicepto capture the deployer's username or object ID, and updated resource group tags to include deployment metadata such as template name, deployment type, creator, and deployment name. This enhances traceability and resource management.principalIdinmain.bicepparamto read from theAZURE_PRINCIPAL_IDenvironment variable, improving automation and consistency across deployments.Script Compatibility:
$env:TEMPis set inpreprovision-integrated.ps1, addressing compatibility for Linux environments where this variable may not be defined by default.Does this introduce a breaking change?