Conversation
Add Manager export
| DelegatedPermission = 'User.Read.All' | ||
| ApplicationPermission = 'User.Read.All' | ||
| } | ||
| ) |
There was a problem hiding this comment.
Missing the closing },. Otherwise looks good!
There was a problem hiding this comment.
Pull request overview
This PR adds manager export functionality to the EntraExporter tool to address Issue #42. The change enables exporting user manager information, which is not included in default user properties. Manager data will be exported in a separate folder containing JSON files with id, userPrincipalName, and displayName.
Changes:
- Added a Children configuration to the Users schema definition to export manager information via the Microsoft Graph API endpoint
users/<placeholder>/manager
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| DelegatedPermission = 'User.Read.All' | ||
| ApplicationPermission = 'User.Read.All' | ||
| } | ||
| ) |
There was a problem hiding this comment.
Missing closing brace and comma after the Children array. The Users configuration object needs to be closed with }, after line 848. This follows the same pattern seen in other schema definitions (e.g., lines 690, 744, 826).
| ) | |
| ) | |
| }, |
| GraphUri = 'users/<placeholder>/manager' | ||
| Path = 'Manager' | ||
| Select = 'id, userPrincipalName, displayName' | ||
| Tag = @('All', 'Users') | ||
| DelegatedPermission = 'User.Read.All' | ||
| ApplicationPermission = 'User.Read.All' | ||
| } |
There was a problem hiding this comment.
Inconsistent indentation. The properties inside this child object use excessive spaces/tabs instead of following the consistent indentation pattern seen in other Children definitions throughout the file. Compare with similar definitions on lines 78-85, 673-688, or 707-742 for the correct indentation pattern.
| GraphUri = 'users/<placeholder>/manager' | |
| Path = 'Manager' | |
| Select = 'id, userPrincipalName, displayName' | |
| Tag = @('All', 'Users') | |
| DelegatedPermission = 'User.Read.All' | |
| ApplicationPermission = 'User.Read.All' | |
| } | |
| GraphUri = 'users/<placeholder>/manager' | |
| Path = 'Manager' | |
| Select = 'id, userPrincipalName, displayName' | |
| Tag = @('All', 'Users') | |
| DelegatedPermission = 'User.Read.All' | |
| ApplicationPermission = 'User.Read.All' | |
| } |
There was a problem hiding this comment.
Valid. Formatting with VS Code should fix this (Shift + Alt + F).
2 participants
PR for Issue #42