Fix: Correct obrSegmentPositionIndex_orc increment to ensure proper ORC parent detection in ORU_R01.liquid#606
Open
Delne wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Put it in OBR for loop instead of OBX for loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #605
This change ensures that
obrSegmentPositionIndex_orcis incremented correctly inside the OBR loop rather than the OBX loop.Previously,
checkParentalways referenced the first ORC segment depending on message structure, instead of the actual ORC parent of the current OBR.By adjusting the position index logic, the correct ORC-OBR relationship is now maintained.