revert: remove SERVTD_ATTR vs INIT_ATTR check#189
Merged
haitaohuang merged 1 commit intoMay 28, 2026
Conversation
Revert the cur_servtd_attr == init_attr comparison (intel/MigTD PR intel#832). After rebind, CURR_SERVTD_ATTR can legitimately differ from INIT_ATTR. The hardcoded check (cur == 0x0) remains sufficient. Signed-off-by: Haitao Huang <haitaohuang@microsoft.com>
There was a problem hiding this comment.
Pull request overview
This PR reverts a recently added validation that required CURR_SERVTD_ATTR to match INIT_ATTR, based on the observation that after rebind the current Service TD attributes can legitimately differ from the init-time attributes. The remaining validation checks CURR_SERVTD_ATTR only against the hardcoded expected value (currently EXPECTED_SERVTD_ATTR = 0) per the referenced GHCI 1.5 requirement.
Changes:
- Removed
CURR_SERVTD_ATTR == INIT_ATTRvalidation inread_servtd_ext. - Removed the
TDCS_FIELD_SERVTD_INIT_ATTRread/compare fromverify_servtd_attr, leaving only the hardcoded attribute check. - Simplified related log messages and doc comments to reflect the single hardcoded check.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert the cur_servtd_attr == init_attr comparison (intel/MigTD PR intel#832). After rebind, CURR_SERVTD_ATTR can legitimately differ from INIT_ATTR. The hardcoded check (cur == 0x0) remains sufficient.