Skip to content

COPY of PR #2359#2463

Closed
shaahji wants to merge 27 commits into
mainfrom
liujij/feat-sd-models
Closed

COPY of PR #2359#2463
shaahji wants to merge 27 commits into
mainfrom
liujij/feat-sd-models

Conversation

@shaahji
Copy link
Copy Markdown
Collaborator

@shaahji shaahji commented May 13, 2026

Copy of PR #2359

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link

@liujij
Copy link
Copy Markdown
Contributor

liujij commented May 15, 2026

Hi @shaahji Could you please sync with PR2359 and retrigger the Olive CI? Thanks a lot!

Comment thread test/passes/vitis_ai/test_vitis_generate_model_sd.py Fixed
Comment thread test/passes/vitis_ai/test_vitis_generate_model_sd.py Fixed
Comment thread test/passes/vitis_ai/test_vitis_generate_model_sd.py Fixed
Comment thread test/passes/vitis_ai/test_vitis_generate_model_sd.py Fixed
@shaahji
Copy link
Copy Markdown
Collaborator Author

shaahji commented May 19, 2026

Hi @shaahji Could you please sync with PR2359 and retrigger the Olive CI? Thanks a lot!

Hey @liujij, build is reporting a few lint error. Could you please fix them. Thanks!

@jambayk jambayk closed this May 20, 2026
@jambayk jambayk reopened this May 20, 2026
@liujij
Copy link
Copy Markdown
Contributor

liujij commented May 21, 2026

Hi @shaahji Could you please sync with PR2359 and retrigger the Olive CI? Thanks a lot!

Hey @liujij, build is reporting a few lint error. Could you please fix them. Thanks!

@shaahji Done

@shaahji
Copy link
Copy Markdown
Collaborator Author

shaahji commented May 26, 2026

Hi @shaahji Could you please sync with PR2359 and retrigger the Olive CI? Thanks a lot!

Hey @liujij, build is reporting a few lint error. Could you please fix them. Thanks!

@shaahji Done

You still got lint problems. You can verify lint issues locally before you commit.

@liujij
Copy link
Copy Markdown
Contributor

liujij commented May 27, 2026

Hi @shaahji Could you please sync with PR2359 and retrigger the Olive CI? Thanks a lot!

Hey @liujij, build is reporting a few lint error. Could you please fix them. Thanks!

@shaahji Done

You still got lint problems. You can verify lint issues locally before you commit.

@shaahji Updated, and there are no lint issues in my local environment.
image

@shaahji
Copy link
Copy Markdown
Collaborator Author

shaahji commented May 27, 2026

PR #2359 merged in favor of this PR.

@shaahji shaahji closed this May 27, 2026
@shaahji shaahji deleted the liujij/feat-sd-models branch May 27, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants