enable mobius in fast tests and align discrepancy smoke CLI flows#2493
Open
xadupre wants to merge 7 commits into
Open
enable mobius in fast tests and align discrepancy smoke CLI flows#2493xadupre wants to merge 7 commits into
xadupre wants to merge 7 commits into
Conversation
xadupre
commented
Jun 2, 2026
xadupre
commented
Jun 2, 2026
xadupre
commented
Jun 2, 2026
Copilot
AI
changed the title
enable mobius in fast tests
enable mobius in fast tests and align discrepancy smoke CLI flows
Jun 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CLI smoke/discrepancy test to support multiple “exporters” (model builder, Mobius, torch-export) and to drive discrepancy checks through a consistent olive run --config ... --test ... --output_path ... flow.
Changes:
- Added exporter selection (
--exporter) and refactored discrepancy runs into exporter-specific helpers plus a sharedrun --config --test --output_pathhelper. - Added Mobius and torch-export discrepancy run-config generation paths (MobiusBuilder and OnnxConversion respectively).
- Introduced optional Mobius availability detection via
importlib.util.find_spec.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fast tests only checked modelbuilder; this PR adds Mobius coverage in the smoke test path.
Addressed review feedback by adding the missing
--testargument to the Mobiusruninvocation intest/cli/test_cli_test_model_smoke.py, aligning it with the documented/tested run flow.Also addressed follow-up feedback by fusing the common
run --config --test --output_pathlogic used by both modelbuilder and Mobius discrepancy smoke tests into a shared helper to reduce duplication.Finally, aligned the torch-export discrepancy path with the same command-line flow by switching it to use a CLI
runconfig (withOnnxConversion) and--test, so all discrepancy smoke paths follow a consistent pattern.Checklist before requesting a review
lintrunner -a(Optional) Issue link