Skip to content

enable mobius in fast tests and align discrepancy smoke CLI flows#2493

Open
xadupre wants to merge 7 commits into
mainfrom
xadupre/mobius
Open

enable mobius in fast tests and align discrepancy smoke CLI flows#2493
xadupre wants to merge 7 commits into
mainfrom
xadupre/mobius

Conversation

@xadupre
Copy link
Copy Markdown
Member

@xadupre xadupre commented Jun 2, 2026

Describe your changes

Fast tests only checked modelbuilder; this PR adds Mobius coverage in the smoke test path.

Addressed review feedback by adding the missing --test argument to the Mobius run invocation in test/cli/test_cli_test_model_smoke.py, aligning it with the documented/tested run flow.

Also addressed follow-up feedback by fusing the common run --config --test --output_path logic used by both modelbuilder and Mobius discrepancy smoke tests into a shared helper to reduce duplication.

Finally, aligned the torch-export discrepancy path with the same command-line flow by switching it to use a CLI run config (with OnnxConversion) and --test, so all discrepancy smoke paths follow a consistent pattern.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link

Comment thread test/cli/test_cli_test_model_smoke.py Outdated
Comment thread test/cli/test_cli_test_model_smoke.py
Comment thread test/cli/test_cli_test_model_smoke.py Outdated
Copilot AI changed the title enable mobius in fast tests enable mobius in fast tests and align discrepancy smoke CLI flows Jun 2, 2026
@xadupre xadupre marked this pull request as ready for review June 2, 2026 16:57
Copilot AI review requested due to automatic review settings June 2, 2026 16:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CLI smoke/discrepancy test to support multiple “exporters” (model builder, Mobius, torch-export) and to drive discrepancy checks through a consistent olive run --config ... --test ... --output_path ... flow.

Changes:

  • Added exporter selection (--exporter) and refactored discrepancy runs into exporter-specific helpers plus a shared run --config --test --output_path helper.
  • Added Mobius and torch-export discrepancy run-config generation paths (MobiusBuilder and OnnxConversion respectively).
  • Introduced optional Mobius availability detection via importlib.util.find_spec.

Comment thread test/cli/test_cli_test_model_smoke.py Outdated
Comment thread test/cli/test_cli_test_model_smoke.py
Comment thread test/cli/test_cli_test_model_smoke.py Outdated
Comment thread test/cli/test_cli_test_model_smoke.py
xadupre and others added 3 commits June 2, 2026 19:03
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants