Skip to content

Fix ontology school review issues 12 to 16 for fibo loans lab#47

Open
ravi-chandu wants to merge 4 commits into
microsoft:mainfrom
ravi-chandu:fix/fibo-loans-lab-review-12-16
Open

Fix ontology school review issues 12 to 16 for fibo loans lab#47
ravi-chandu wants to merge 4 commits into
microsoft:mainfrom
ravi-chandu:fix/fibo-loans-lab-review-12-16

Conversation

@ravi-chandu

Copy link
Copy Markdown
Contributor

Summary

This PR resolves the open Ontology School review issues for the fibo loans lab lessons by correcting source provenance, module references, and attribution wording across all 5 steps.

What Was Fixed

Scenario Overview

  • Corrected and expanded module mapping to align with actual LOAN, FBC, and FND source coverage.
  • Tightened source attribution and licensing wording for accuracy.

Core Loan Triad

  • Corrected class provenance in lesson text:
    • Loan from LOAN
    • Borrower and Lender role concepts from FBC Debt (as used by LOAN)
  • Updated related citation language.

Collateral and Schedules

  • Corrected collateral and mortgage restriction explanation to match Debt and Mortgages ontology semantics.
  • Confirmed diff embed reference is correct.

Servicing and Payment History

  • Corrected PaymentHistory and payment transaction provenance to LOAN concepts with explicit linkage to ClientsAndAccounts patterns.
  • Clarified the audit trail modeling explanation.
  • Quiz reviewed and kept correct.

Risk and Classifiers

  • Corrected OwnershipInterest and LenderLienPosition provenance to LOAN concepts, with Ownership grounding noted.
  • Improved Mortgages and Loans reference links.
  • Updated further reading and licensing wording.

Files Changed

  • content/learn/fibo-loans-lab/01-scenario-overview.md
  • content/learn/fibo-loans-lab/02-core-loan-triad.md
  • content/learn/fibo-loans-lab/03-collateral-and-schedules.md
  • content/learn/fibo-loans-lab/04-servicing-and-payment-history.md
  • content/learn/fibo-loans-lab/05-risk-and-classifiers.md
  • public/learn.json (regenerated)

Validation

Full build completed successfully:

  1. catalogue compile
  2. learn compile
  3. app production build
  4. embed build

Closes

…ing path

Catalogue entry:
- 8 entity types: Supplier, Component, ProductLine, DisruptionEvent,
  RiskAssessment, MitigationAction, AlternativeSupplier
- 40+ data properties (reliability scores, inventory levels, lead times,
  risk assessments, cost/revenue metrics)
- 7 object properties modeling full disruption cascade:
  disruption → supplier impact → component risk → product exposure →
  risk assessment → mitigation action → alternative supplier activation
- Fabric IQ validated (no self-references, proper enum sets)
- Author: Ravi Chandu Edru

Learning path (4 articles):
- 01 Scenario Overview: real-world disruption cascades and the business case
- 02 Core Entities and Properties: 8 entity types with full property reference
- 03 Risk Propagation Model: 7 relationships and cascade diagram
- 04 Mitigation Execution and Automation: Fabric IQ agent workflows end-to-end

Tests:
- Updated catalogue entry count from 53 to 54

HR System:
- Updated author to Ravi Chandu Edru
- correct FIBO module and class provenance across steps 1-5

- refine references, further reading links, and licensing wording

- regenerate learn.json via learn build
…review-12-16

# Conflicts:
#	public/learn.json
#	scripts/compile-catalogue.test.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant