Handle empty CSV exports in remote dataset cache#1481
Merged
romanlutz merged 3 commits intomicrosoft:mainfrom Apr 12, 2026
Merged
Handle empty CSV exports in remote dataset cache#1481romanlutz merged 3 commits intomicrosoft:mainfrom
romanlutz merged 3 commits intomicrosoft:mainfrom
Conversation
romanlutz
approved these changes
Mar 16, 2026
…_csv tests - Add round-trip read_cache assertion to verify empty CSV can be read back as [] - Add dedicated test_csv_helper.py with direct unit tests for write_csv Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_RemoteDatasetLoader._write_cache(..., file_type="csv")with no rowsProblem
_RemoteDatasetLoaderroutes CSV cache writes throughpyrit.common.csv_helper.write_csv(). That helper currently assumesexamples[0]exists, so exporting or caching an empty CSV-backed dataset raisesIndexErrorinstead of producing an empty file like the JSON, JSONL, and TXT helpers already do.Testing
.venv/bin/pytest tests/unit/datasets/test_remote_dataset_loader.py -q